HW41-solution #56
Open
HW41-solution #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerrrusha
approved these changes
Nov 13, 2023
Comment on lines
10
to
21
| private static RickAndMortyClient rickAndMortyClient; | ||
| private static RickAndMortyService rickAndMortyService; | ||
|
|
||
| public Application(RickAndMortyClient client, RickAndMortyService rickAndMortyService) { | ||
| Application.rickAndMortyClient = client; | ||
| Application.rickAndMortyService = rickAndMortyService; | ||
| } | ||
|
|
||
| public static void main(String[] args) { | ||
| SpringApplication.run(Application.class, args); | ||
| rickAndMortyService.saveAll(rickAndMortyClient.getAllCharacter()); | ||
| } |
There was a problem hiding this comment.
use CommandLineRunner or ApplicationRunner instead of running this here
Suggested change
| private static RickAndMortyClient rickAndMortyClient; | |
| private static RickAndMortyService rickAndMortyService; | |
| public Application(RickAndMortyClient client, RickAndMortyService rickAndMortyService) { | |
| Application.rickAndMortyClient = client; | |
| Application.rickAndMortyService = rickAndMortyService; | |
| } | |
| public static void main(String[] args) { | |
| SpringApplication.run(Application.class, args); | |
| rickAndMortyService.saveAll(rickAndMortyClient.getAllCharacter()); | |
| } | |
| public static void main(String[] args) { | |
| SpringApplication.run(Application.class, args); | |
| } |
| public List<CharacterRateDto> getAllCharacter() { | ||
| HttpClient httpClient = HttpClient.newHttpClient(); | ||
| int i = 1; | ||
| List<CharacterRateDto> allCharacter = new ArrayList<>(); |
There was a problem hiding this comment.
better naming
Suggested change
| List<CharacterRateDto> allCharacter = new ArrayList<>(); | |
| List<CharacterRateDto> fetchedCharacters = new ArrayList<>(); |
|
|
||
| public List<CharacterRateDto> getAllCharacter() { | ||
| HttpClient httpClient = HttpClient.newHttpClient(); | ||
| int i = 1; |
There was a problem hiding this comment.
better naming
Suggested change
| int i = 1; | |
| int page = 1; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.