Create Rick & Morty API #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-hoienko
suggested changes
Oct 19, 2023
| } | ||
| ); | ||
| } catch (IOException | InterruptedException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
It is better to throw custom exception instead of generic one
| @EventListener(ApplicationReadyEvent.class) | ||
| public void fetchData() { | ||
| List<ExternalCharacterDto> characters = new ArrayList<>(); | ||
| CharacterResponseDataDto response = loadData(characterUrl); |
There was a problem hiding this comment.
Suggested change
| CharacterResponseDataDto response = loadData(characterUrl); | |
| CharacterResponseDataDto characterResponse = loadData(characterUrl); |
| service.saveAll(characters); | ||
| } | ||
|
|
||
| private CharacterResponseDataDto loadData(String url) { |
There was a problem hiding this comment.
OPTIONAL: As an alternative way to make http requests it is possible to use feignClient, which from my point of view is a more suitable and agile way of making web clients and request. But actually for current task your solution in ok as well
vovasalyha
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.