init structure, add liquibase #9
Conversation
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.liquibase</groupId> | ||
| <artifactId>liquibase-core</artifactId> | ||
| <version>${liquibase.version}</version> |
There was a problem hiding this comment.
there is no need to specify the version - it is taken from spring-boot-starter-parent
| @Component | ||
| @RequiredArgsConstructor | ||
| public class RickAndMortyApiClient { | ||
| private static final String BASE_CHARACTER_URL = "https://rickandmortyapi.com/api/character"; |
There was a problem hiding this comment.
this property should be stored in application properties and referenced via @Value
|
|
||
| @GetMapping("/search") | ||
| public List<PersonageResponseDto> getPersonageByName( | ||
| Pageable pageable, @RequestParam String name |
There was a problem hiding this comment.
you may make use of @PageableDefault here in case client did not provide pagination parameters
| import lombok.Data; | ||
|
|
||
| @Data | ||
| public class ExternalResponseDto { |
| import lombok.Data; | ||
|
|
||
| @Data | ||
| public class Info { |
|
|
||
| public List<Personage> getAllPersonages() { | ||
| List<Result> resultList = new ArrayList<>(); | ||
| ExternalResponseDto externalResponseDto = getExternalResponseDto(BASE_CHARACTER_URL); |
There was a problem hiding this comment.
there is no need to pass the url as a parameter - you can simply access it inside of that method
| request, HttpResponse.BodyHandlers.ofString()); | ||
| return objectMapper.readValue(response.body(), ExternalResponseDto.class); | ||
| } catch (IOException | InterruptedException e) { | ||
| throw new RuntimeException("Can't send request to url: " + url); |
There was a problem hiding this comment.
too generic :)
consider creating your custom exception (P.S. don't forget to handle that)
| @RestController | ||
| @RequiredArgsConstructor | ||
| @RequestMapping("/rick-and-morty") | ||
| public class RickAndMortyController { |
There was a problem hiding this comment.
I don't see any Swagger documentation :)
|
|
||
| @Component | ||
| @RequiredArgsConstructor | ||
| public class DbLoader { |
There was a problem hiding this comment.
| public class DbLoader { | |
| public class PersonageDatabasePopulator { |
| if (personageRepository.count() == 0) { | ||
| personageRepository.saveAll(rickAndMortyApiClient.getAllPersonages()); | ||
| } |
There was a problem hiding this comment.
just wondering - do you need to keep only up-to-date personages?
if yes - then you might need to clear your db first and only then load the latest info from API:
if (personageRepository.count() != 0) {
personageRepository.deleteAll();
}
personageRepository.saveAll(rickAndMortyApiClient.getAllPersonages());
There was a problem hiding this comment.
I did it because in our task description was it: All data from the public API should be fetched once, and only once, when the Application context is created. But I uncorrected understood it, i thought that i had to do it only once
There was a problem hiding this comment.
@teract10s no, you're right - you have to do that API call only once
I'm asking about DB state. imagine that you ran you application 2 times:
- DB is empty - call the API to save the personages
- DB is not empty - call the API to save the personages - a lot of duplicates as a result
| import org.springframework.web.bind.annotation.ExceptionHandler; | ||
| import org.springframework.web.servlet.mvc.method.annotation.ResponseEntityExceptionHandler; | ||
|
|
||
| public class CustomGlobalExceptionHandler extends ResponseEntityExceptionHandler { |
There was a problem hiding this comment.
don't you need @ControllerAdvice?
| import org.springframework.web.servlet.mvc.method.annotation.ResponseEntityExceptionHandler; | ||
|
|
||
| public class CustomGlobalExceptionHandler extends ResponseEntityExceptionHandler { | ||
| @ExceptionHandler(SendingRequestException.class) |
There was a problem hiding this comment.
where this exception is thrown? I didn't find that place
There was a problem hiding this comment.
Ops. I forgot to delete this after reformat RickAndMortyClient
|
|
||
| @Component | ||
| @RequiredArgsConstructor | ||
| public class RickAndMortyApiClient { |
There was a problem hiding this comment.
minor
may be simplified to RickAndMortyClient
| public class ThirdPartyApiConfiguration { | ||
| @Bean | ||
| public RestTemplate getRestTemplate() { |
There was a problem hiding this comment.
| public class ThirdPartyApiConfiguration { | |
| @Bean | |
| public RestTemplate getRestTemplate() { | |
| public class ApiClientConfiguration { | |
| @Bean | |
| public RestTemplate restTemplate() { |
| @RestController | ||
| @RequiredArgsConstructor | ||
| @RequestMapping("/rick-and-morty") | ||
| public class RickAndMortyController { |
| import org.springframework.data.domain.Pageable; | ||
|
|
||
| public interface PersonageService { | ||
|
|
|
|
||
| @ControllerAdvice | ||
| public class CustomGlobalExceptionHandler extends ResponseEntityExceptionHandler { | ||
| @ExceptionHandler(Exception.class) |
There was a problem hiding this comment.
?
| @ExceptionHandler(Exception.class) | |
| @ExceptionHandler(EntityNotFoundException.class) |
| public class CustomGlobalExceptionHandler extends ResponseEntityExceptionHandler { | ||
| @ExceptionHandler(Exception.class) | ||
| public ResponseEntity<Object> handleEntityNotFound(Exception ex) { | ||
| return new ResponseEntity<>(ex.getMessage(), HttpStatus.SERVICE_UNAVAILABLE); |
There was a problem hiding this comment.
| return new ResponseEntity<>(ex.getMessage(), HttpStatus.SERVICE_UNAVAILABLE); | |
| return new ResponseEntity<>(ex.getMessage(), HttpStatus.NOT_FOUND); |
No description provided.