done #312
Open
done #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olekskov
approved these changes
Jul 23, 2023
| public interface ProductRepository extends JpaRepository<Product, Long> { | ||
| List<Product> findAllByPriceBetween(BigDecimal from, BigDecimal to); | ||
|
|
||
| List<Product> findAllByCategoryId(Long categories); |
There was a problem hiding this comment.
Plurals are used for Collections, Long with plural naming looks confusing
Suggested change
| List<Product> findAllByCategoryId(Long categories); | |
| List<Product> findAllByCategoryId(Long categoryId); |
There was a problem hiding this comment.
Yes, in the first version I wanted to use List there
|
|
||
| List<Product> getAllWherePriceBetween(BigDecimal priceMin, BigDecimal priceMax); | ||
|
|
||
| List<Product> getAllInCategories(Long categoryId); |
There was a problem hiding this comment.
Naming with "in" is usually used when we have List as argument to indicate we check all values in list. So such naming here is slightly confusing
Suggested change
| List<Product> getAllInCategories(Long categoryId); | |
| List<Product> getAllByCategory(Long categoryId); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.