Created simple app for working with products and its categories #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gamemod13
approved these changes
Aug 17, 2023
| @RequestParam BigDecimal priceTo) { | ||
| return productService.getAllByPriceBetween(priceFrom, priceTo).stream() | ||
| .map(dtoMapper::toDto) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
You can use short option
Suggested change
| .collect(Collectors.toList()); | |
| .toList(); |
| public List<ProductResponseDto> getAllByCategoryIds(@RequestParam Set<Long> categoryIds) { | ||
| List<Product> allByCategoryIds = productService.getAllByCategoryIds(categoryIds); | ||
| return allByCategoryIds.stream() | ||
| .map(dtoMapper::toDto).collect(Collectors.toList()); |
There was a problem hiding this comment.
Suggested change
| .map(dtoMapper::toDto).collect(Collectors.toList()); | |
| .map(dtoMapper::toDto).toList(); |
There was a problem hiding this comment.
Yeah, you are right. But I'm not using toList() in homework cos this method appears in Java 16 but most of our homework uses Java 11. I missed that this task is using Java 17. Also, I had some problems before with List immutability after using the "toList()" method, so...
|
|
||
| @Data | ||
| public class CategoryResponseDto { | ||
| private Long id; |
There was a problem hiding this comment.
Yep, I want to return the ID of the saved element
|
|
||
| @Data | ||
| public class ProductResponseDto { | ||
| private Long id; |
There was a problem hiding this comment.
The same, do you realy need send id in Response?
Comment on lines
+13
to
+14
| @Getter | ||
| @Setter |
There was a problem hiding this comment.
You can use one annotation Data
Suggested change
| @Getter | |
| @Setter | |
| @Data |
There was a problem hiding this comment.
sarakhmen
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.