Hw jv2 #320
Hw jv2 #320
Conversation
| return categoryRepository.findById(id).orElseThrow(() | ||
| -> new NoSuchElementException("Can`t find ")); | ||
| } |
There was a problem hiding this comment.
| return categoryRepository.findById(id).orElseThrow(() | |
| -> new NoSuchElementException("Can`t find ")); | |
| } | |
| return categoryRepository.findById(id).orElseThrow(() | |
| -> new NoSuchElementException("Can`t find category by id: " + id)); | |
| } |
| import lombok.Data; | ||
| import lombok.EqualsAndHashCode; | ||
|
|
||
| @Data |
There was a problem hiding this comment.
let's try to not use Data annotaion for entities. Better to use Getter Setter EqualsAndHashCode etc.
please check other entities.
| List<Product> findAllByPriceBetween(BigDecimal from, BigDecimal to); | ||
|
|
||
| List<Product> findAllByCategoryNameIn(List<String> categoryName); | ||
|
|
| package mate.academy.springboot.datajpa.service; | ||
|
|
||
| public interface GeneralService<T> { | ||
| T create(T model); |
There was a problem hiding this comment.
let's rename this method for better matching what this method do and better code readability
| T create(T model); | |
| T save(T model); |
| public class CategoryServiceImpl implements CategoryService { | ||
| private final CategoryRepository categoryRepository; | ||
|
|
||
| public CategoryServiceImpl(CategoryRepository categoryRepository) { |
There was a problem hiding this comment.
you can use the lombok annotations for creating a needed constructor and simplify the code.
| public class ProductServiceImpl implements ProductService { | ||
| private final ProductRepository productRepository; | ||
|
|
||
| public ProductServiceImpl(ProductRepository productRepository) { |
There was a problem hiding this comment.
you can use the lombok annotations for creating a needed constructor and simplify the code.
| } | ||
|
|
||
| @Override | ||
| public List<Product> findAllByCategoryNameIn(List<String> categoryName) { |
There was a problem hiding this comment.
| public List<Product> findAllByCategoryNameIn(List<String> categoryName) { | |
| public List<Product> findAllByCategoryNameIn(List<String> categoryNames) { |
|
|
||
| @GetMapping("/by-categories") | ||
| public List<ProductResponseDto> getAllByCategories(@RequestParam String[] categoriesId) { | ||
| return productService.findAllByCategoryNameIn(List.of(categoriesId)).stream() |
There was a problem hiding this comment.
Naming inconsistency. It is not clear from the naming of variables the method should receive category names or category ids?
| } | ||
|
|
||
| @GetMapping("/by-categories") | ||
| public List<ProductResponseDto> getAllByCategories(@RequestParam String[] categoriesId) { |
There was a problem hiding this comment.
Use plural in the end of the variable names instead of in the middle, e.g. categoryIds or categoryNames.
Please fix the similar cases in the code.
No description provided.