Implemented all needed repositories/services/controllers #323
Conversation
| @Table(name = "products") | ||
| public class Product { | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) |
There was a problem hiding this comment.
I would like an additional explanation from mentors in this situation)
There was a problem hiding this comment.
I selected the wrong area for the comment, I am interested in this class of entity with the Lazy fetch type
| } | ||
|
|
||
| @GetMapping("/{id}") | ||
| public CategoryResponseDto getByID(@PathVariable Long id) { |
There was a problem hiding this comment.
| public CategoryResponseDto getByID(@PathVariable Long id) { | |
| public CategoryResponseDto get(@PathVariable Long id) { |
| Category category = service.add(mapper.mapToModel(dto)); | ||
| return mapper.mapToDto(category); |
There was a problem hiding this comment.
let's be consistent in your code style. Either use additional variables everywhere or avoid creating it
| } | ||
|
|
||
| @GetMapping("/{id}") | ||
| public ProductResponseDto getByID(@PathVariable Long id) { |
There was a problem hiding this comment.
| public ProductResponseDto getByID(@PathVariable Long id) { | |
| public ProductResponseDto get(@PathVariable Long id) { |
| } | ||
|
|
||
| @GetMapping("/categories") | ||
| public List<ProductResponseDto> getByCategorie(@RequestParam List<String> categoryNames) { |
There was a problem hiding this comment.
| public List<ProductResponseDto> getByCategorie(@RequestParam List<String> categoryNames) { | |
| public List<ProductResponseDto> getByCategory(@RequestParam List<String> categoryNames) { |
| import java.math.BigDecimal; | ||
| import lombok.Data; | ||
|
|
||
| @Data |
There was a problem hiding this comment.
Let's not use @Data annotation. It's better to use Getter Setter etc. Please fix the same issue in all places
| + "id=" + id | ||
| + ", title='" + title + '\'' | ||
| + ", price=" + price | ||
| + ", category=" + category |
There was a problem hiding this comment.
please pay attention to @V-Solianyk comment and remove 'category' from toString method
No description provided.