done #325
Open
done #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarakhmen
suggested changes
Aug 31, 2023
| return mapper.mapToDto(category); | ||
| } | ||
|
|
||
| @GetMapping |
There was a problem hiding this comment.
don't you forget to specify path variable within URL here? Fix the same issue in all places
Suggested change
| @GetMapping | |
| @GetMapping("/{id}") |
| import java.math.BigDecimal; | ||
| import lombok.Data; | ||
|
|
||
| @Data |
There was a problem hiding this comment.
let's try not to use Data annotation for entities. It's better to use Getter Setter etc.
please check other entities.
| private BigDecimal price; | ||
| private Category category; | ||
| } | ||
|
|
| @Component | ||
| public class CategoryMapperImpl implements DtoMapper<RequestCategoryDto, | ||
| ResponseCategoryDto, Category> { | ||
|
|
There was a problem hiding this comment.
Suggested change
fix the same issue in all places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.