Homework: JV Spring Boot Data JPA #326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarakhmen
approved these changes
Aug 30, 2023
pom.xml
Outdated
Comment on lines
51
to
55
| <dependency> | ||
| <groupId>com.mysql</groupId> | ||
| <artifactId>mysql-connector-j</artifactId> | ||
| <scope>runtime</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Not really)
I tested the code on MySQL and forgot about this dependency
|
|
||
| import lombok.Data; | ||
|
|
||
| @Data |
There was a problem hiding this comment.
Let's not use @Data annotation. It's better to use Getter Setter etc. Please fix the same issue in all places
| @Component | ||
| public class CategoryMapperImpl implements DtoMapper<CategoryRequestDto, | ||
| CategoryResponseDto, Category> { | ||
|
|
There was a problem hiding this comment.
Suggested change
Please remove redundant empty lines in all places
| @Override | ||
| public Category getById(Long id) { | ||
| return categoryRepository.findById(id).orElseThrow(() -> | ||
| new RuntimeException("Can't find a category by id: " + id)); |
There was a problem hiding this comment.
It's better to use NoSuchElementException here
sarakhmen
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.