-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #6095
base: master
Are you sure you want to change the base?
Develop #6095
Changes from all commits
dde9bc3
34c8079
1ad89f7
334179f
1188659
b1bb363
ab3bdd2
e93b3da
d9fbf0f
05b11c9
1c660fd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: Test | ||
|
||
on: | ||
pull_request: | ||
branches: [ master ] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
matrix: | ||
node-version: [20.x] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: npm install | ||
- run: npm test | ||
- name: Upload HTML report(backstop data) | ||
if: ${{ always() }} | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: report | ||
path: backstop_data |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,117 @@ | ||
:root { | ||
--margin: 0; | ||
--padding: 0; | ||
--box-sizing: border-box; | ||
--accent-color: #00acdc; | ||
--body-bg-color: aliceblue; | ||
--header-bg-color: #fff; | ||
--nav-link-height: 60px; | ||
--logo-size: 40px; | ||
--header-padding: 50px; | ||
} | ||
|
||
body, | ||
header, | ||
nav, | ||
ul, | ||
li, | ||
a, | ||
img { | ||
box-sizing: var(--box-sizing); | ||
margin: var(--margin); | ||
padding: var(--padding); | ||
} | ||
|
||
body { | ||
margin: 0; | ||
font-family: Roboto, sans-serif; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider adding fallback fonts to the |
||
background-color: var(--body-bg-color); | ||
margin: var(--margin); | ||
} | ||
|
||
.header { | ||
display: flex; | ||
justify-content: space-between; | ||
align-items: center; | ||
padding-inline: var(--header-padding); | ||
width: 100%; | ||
min-height: 60px; | ||
background-color: var(--header-bg-color); | ||
} | ||
|
||
.header__logo { | ||
display: block; | ||
width: var(--logo-size); | ||
height: var(--logo-size); | ||
} | ||
|
||
.header__logo img { | ||
max-width: 100%; | ||
height: auto; | ||
} | ||
|
||
.nav-menu { | ||
margin: var(--margin); | ||
padding: var(--padding); | ||
} | ||
|
||
.nav-menu__list { | ||
display: flex; | ||
list-style: none; | ||
} | ||
|
||
.nav-menu__item { | ||
display: flex; | ||
align-items: center; | ||
} | ||
|
||
.nav-menu__item:not(:last-child) { | ||
margin-right: 20px; | ||
} | ||
|
||
.nav-menu__link { | ||
display: flex; | ||
align-items: center; | ||
text-decoration: none; | ||
color: black; | ||
font-weight: 500; | ||
height: var(--nav-link-height); | ||
disiol marked this conversation as resolved.
Show resolved
Hide resolved
|
||
font-size: 12px; | ||
text-transform: uppercase; | ||
transition: color 0.3s ease; | ||
} | ||
|
||
.nav-menu__link:hover { | ||
color: var(--accent-color); | ||
} | ||
|
||
.is-active { | ||
position: relative; | ||
color: var(--accent-color); | ||
} | ||
|
||
.is-active::after { | ||
content: ''; | ||
position: absolute; | ||
left: 0; | ||
bottom: 0; | ||
width: 100%; | ||
height: 4px; | ||
background-color: var(--accent-color); | ||
border-radius: 8px; | ||
} | ||
|
||
html { | ||
scroll-behavior: smooth; | ||
} | ||
|
||
@media (max-width: 768px) { | ||
.header { | ||
flex-direction: column; | ||
align-items: center; | ||
} | ||
|
||
.nav-menu__list { | ||
flex-direction: column; | ||
gap: 10px; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
href
attribute for the logo link is set to/
, which may not provide meaningful navigation. Consider linking it to the homepage or a relevant section as per the previous review suggestion.