solution #101
Open
solution #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanilWeda
suggested changes
May 22, 2024
src/createServer.js
Outdated
Comment on lines
15
to
27
| if (normalizedText === '/') { | ||
| await httpGetMainPage(res); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| const verifiedPath = httpVerifyRequest(res, normalizedText, method); | ||
|
|
||
| if (!verifiedPath) { | ||
| return; | ||
| } | ||
|
|
||
| if (method === 'POST' && normalizedText === '/compress') { |
There was a problem hiding this comment.
'/' and '/compress' move in constants.
Also, all methods ( 'POST' and others) move to constants.
Finally, move all statuses in constants. ( for all files)
Then use their in all files.
Thanks)
There was a problem hiding this comment.
@DanilWeda I will make it on my laptop, because I like this approach, but I will not commit new changes)
Is it ok for you?
Tests work awful I am afraid to move something while the result is green)))
There was a problem hiding this comment.
After the first attempt, I had 3 errors.
Then I did nothing and only one mistake is left)
But as you can see from the screen - everything works properly)
|
I have found the mistake. And have updated the code) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi)
Have a nice day)