the task was done #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loralevitska
suggested changes
Sep 21, 2023
|
|
||
| const PORT = 8080; | ||
|
|
||
| const server = http.createServer((req, res) => { |
There was a problem hiding this comment.
The server does not provide a way for the user to select a compression type. The Brotli compression is used by default.
src/index.js
Outdated
|
|
||
| const http = require('http'); | ||
| const fs = require('fs'); | ||
| const zlip = require('zlib'); |
There was a problem hiding this comment.
There's a typo in the require statement for 'zlib'. It should be 'zlib' not 'zlip'.
src/index.js
Outdated
| pipeline(fileStream, brotli, res, (error) => { | ||
| if (error) { | ||
| res.statusCode = 500; | ||
| res.setHeader('Content-Type', 'text/plain'); |
There was a problem hiding this comment.
The 'Content-Type' header is set to 'text/plain' in case of an error. Consider using 'text/html' or 'application/json' for a more structured error message.
src/index.js
Outdated
| const path = require('path'); | ||
| const { pipeline } = require('stream'); | ||
|
|
||
| const PORT = 8080; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.