-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #60
base: master
Are you sure you want to change the base?
Solution #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, but also need to add html page with form where you can choose compression type and choose file for it
src/index.js
Outdated
fileStream | ||
.on('error', () => {}) | ||
.pipe(gzip) | ||
.on('error', () => {}) | ||
.pipe(res) | ||
.on('error', () => {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here would be better to use pipeline
src/index.js
Outdated
// const gzip = zlib.createGzip(); | ||
|
||
// pipeline(fileStream, gzip, res, () => {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove all comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done)
No description provided.