Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #60

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Solution #60

wants to merge 4 commits into from

Conversation

katerinalex
Copy link

No description provided.

Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but also need to add html page with form where you can choose compression type and choose file for it

src/index.js Outdated
Comment on lines 29 to 34
fileStream
.on('error', () => {})
.pipe(gzip)
.on('error', () => {})
.pipe(res)
.on('error', () => {});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here would be better to use pipeline

src/index.js Outdated
Comment on lines 43 to 45
// const gzip = zlib.createGzip();

// pipeline(fileStream, gzip, res, () => {});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove all comments

Copy link

@loralevitska loralevitska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants