-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #604
Open
andriiovod
wants to merge
2
commits into
mate-academy:master
Choose a base branch
from
andriiovod:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Solution #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsmutok
suggested changes
Oct 8, 2024
app/main.py
Outdated
Comment on lines
66
to
75
try: | ||
limitations = self.limitation_class(visitor.age, | ||
visitor.weight, visitor.height) | ||
return ( | ||
limitations.age >= visitor.age | ||
and limitations.weight >= visitor.weight | ||
and limitations.height >= visitor.height | ||
) | ||
except ValueError: | ||
return False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
try: | |
limitations = self.limitation_class(visitor.age, | |
visitor.weight, visitor.height) | |
return ( | |
limitations.age >= visitor.age | |
and limitations.weight >= visitor.weight | |
and limitations.height >= visitor.height | |
) | |
except ValueError: | |
return False | |
def can_access(self, visitor: Visitor) -> bool: | |
try: | |
self.limitation_class(visitor.age, visitor.weight, visitor.height) | |
return True | |
except ValueError: | |
return False |
app/main.py
Outdated
Comment on lines
47
to
51
def __init__(self, age: int, weight: int, height: int) -> None: | ||
super().__init__(age, weight, height) | ||
self.age = age | ||
self.weight = weight | ||
self.height = height |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__init__
redundant here
and fixed method 'can_access'.
vasylhnatiuk
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.