-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #607
base: master
Are you sure you want to change the base?
Solution #607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! 👋 Your code is generally well-written, but there are a few issues that need fixing. The can_access
method and the usage of SlideLimitationValidator
subclasses need to be corrected. Also, don't forget to use the IntegerRange
descriptor for age
, weight
, and height
attributes in the Visitor
class. Lastly, adding messages to your exceptions will greatly help with debugging. Keep going, you're almost there! 💪
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code is on the right track, but there are a few areas that need some improvement. The main issue is with the SlideLimitationValidator classes and how they are used. They should make better use of the IntegerRange descriptor. Also, the can_access method in the Slide class can be optimized. Keep going, you're doing great! I'm sure you'll nail it in the next iteration! 💪😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code is generally well-structured and clean, but there are a few areas for improvement. The error message on line 21 may confuse users, and the use of descriptors in the SlideLimitationValidator subclasses could be enhanced. Additionally, the Slide class's can_access method isn't correctly validating visitor attributes. Despite these issues, I'm approving this to encourage you to keep progressing in your learning. Please consider these comments to improve your code in the future. Keep up the good work! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
No description provided.