-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #608
base: master
Are you sure you want to change the base?
Solution #608
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,24 +2,67 @@ | |
|
||
|
||
class IntegerRange: | ||
pass | ||
def __init__( | ||
self, | ||
min_amount: int, | ||
max_amount: int | ||
) -> None: | ||
self.min_amount = min_amount | ||
self.max_amount = max_amount | ||
|
||
def __set_name__(self, instance: "Visitor", name: str) -> None: | ||
self.protected_name = "_" + name | ||
|
||
def __get__(self, instance: "Visitor", owner: object) -> object: | ||
return getattr(instance, self.protected_name) | ||
|
||
def __set__(self, instance: "Visitor", value: int) -> None: | ||
if not isinstance(value, int): | ||
raise TypeError("Expected an integer value") | ||
if not (self.min_amount <= value <= self.max_amount): | ||
raise ValueError("Value out of the allowed range") | ||
setattr(instance, self.protected_name, value) | ||
|
||
|
||
class Visitor: | ||
pass | ||
|
||
def __init__(self, name: str, age: int, weight: int, height: int) -> None: | ||
self.name = name | ||
self.age = age | ||
self.weight = weight | ||
self.height = height | ||
Comment on lines
27
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
|
||
|
||
class SlideLimitationValidator(ABC): | ||
pass | ||
def __init__(self, age: int, weight: int, height: int) -> None: | ||
self.age = age | ||
self.weight = weight | ||
self.height = height | ||
Comment on lines
36
to
+40
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
|
||
|
||
class ChildrenSlideLimitationValidator(SlideLimitationValidator): | ||
pass | ||
age = IntegerRange(4, 14) | ||
weight = IntegerRange(20, 50) | ||
height = IntegerRange(80, 120) | ||
|
||
|
||
class AdultSlideLimitationValidator(SlideLimitationValidator): | ||
pass | ||
age = IntegerRange(14, 60) | ||
weight = IntegerRange(50, 120) | ||
height = IntegerRange(120, 220) | ||
Comment on lines
43
to
+52
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
|
||
|
||
class Slide: | ||
pass | ||
def __init__(self, name: str, | ||
limitation_class: SlideLimitationValidator) -> None: | ||
self.name = name | ||
self.limitation_class = limitation_class | ||
|
||
def can_access(self, visitor: Visitor) -> bool: | ||
try: | ||
self.limitation_class(visitor.age, visitor.weight, visitor.height) | ||
except (ValueError, TypeError)\ | ||
: | ||
return False | ||
else: | ||
return True | ||
Comment on lines
55
to
+68
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
IntegerRange
class is a descriptor that validates if a value is an integer and within a specific range. This is a good use of descriptors to enforce data validation.