'Solution' #609
Open
'Solution' #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nattalli
suggested changes
Oct 14, 2024
app/main.py
Outdated
| self.min_amount = min_amount | ||
| self.max_amount = max_amount | ||
|
|
||
| def __set_name__(self, owner: type, name: str) -> None: |
There was a problem hiding this comment.
Suggested change
| def __set_name__(self, owner: type, name: str) -> None: | |
| def __set_name__(self, owner: SlideLimitationValidator, name: str) -> None: |
app/main.py
Outdated
| def __get__(self, instance: object, owner: type) -> int: | ||
| return getattr(instance, self.protected_name) | ||
|
|
||
| def __set__(self, instance: object, value: int) -> None: |
app/main.py
Outdated
| def __set_name__(self, owner: type, name: str) -> None: | ||
| self.protected_name = f"_{name}" | ||
|
|
||
| def __get__(self, instance: object, owner: type) -> int: |
app/main.py
Outdated
|
|
||
|
|
||
| class Slide: | ||
| pass | ||
| def __init__(self, name: str, limitation_class: type) -> None: |
Arsen-hrynevych
suggested changes
Oct 14, 2024
| self.weight = weight | ||
| self.height = height | ||
|
|
||
|
|
||
| class IntegerRange: |
There was a problem hiding this comment.
The IntegerRange descriptor is supposed to work with class attributes in SlideLimitationValidator (age, height, weight), but the current implementation only sets and gets instance attributes.
| self.name = name | ||
| self.limitation_class = limitation_class | ||
|
|
||
| def can_access(self, visitor: Visitor) -> bool: |
There was a problem hiding this comment.
In the can_access method of the Slide class, you instantiate the limitation_class, but you don't check whether the visitor's parameters fit within the range. To properly verify this, you should instantiate the class and then allow the descriptors (age, height, and weight) to validate the visitor's properties by assigning them one by one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.