Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solutionend #610

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 43 additions & 6 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,25 +1,62 @@
from abc import ABC
from typing import Any


class IntegerRange:
pass
def __init__(self, min_amount: int, max_amount: int) -> None:
self.min_amount = min_amount
self.max_amount = max_amount

def __set_name__(self, owner: Any, name: str) -> None:
self.protected_name = "_" + name

def __get__(self, instance: Any, owner: Any) -> Any:
return getattr(instance, self.protected_name)

def __set__(self, instance: Any, value: Any) -> None:
if not isinstance(value, int):
raise TypeError(f"{value} should be integer!")
if not (self.min_amount <= value <= self.max_amount):
raise ValueError(f"{value} should be between {self.min_amount} and {self.max_amount}")
setattr(instance, self.protected_name, value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IntegerRange class is well implemented. It might be useful to add a docstring to describe its purpose and how it works for future reference.



class Visitor:
pass
def __init__(self, name: str, age: int, weight: int, height: int) -> None:
self.name = name
self.age = age
self.weight = weight
self.height = height


class SlideLimitationValidator(ABC):
pass
def __init__(self, age: int, weight: int, height: int) -> None:
self.age = age
self.weight = weight
self.height = height
Comment on lines 34 to +38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SlideLimitationValidator class is a bit confusing. It seems like it should be a class that validates the limitations for a slide. But in its current form, it's more like a data holder than a validator. You should consider adding a validation method in this class and use it in the Slide class.

Comment on lines 34 to +38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SlideLimitationValidator class doesn't actually validate anything. It should have a method that takes a Visitor instance as a parameter and checks if the visitor meets the age, weight, and height restrictions.



class ChildrenSlideLimitationValidator(SlideLimitationValidator):
pass
age = IntegerRange(4, 14)
weight = IntegerRange(20, 50)
height = IntegerRange(80, 120)


class AdultSlideLimitationValidator(SlideLimitationValidator):
pass
age = IntegerRange(14, 60)
weight = IntegerRange(50, 120)
height = IntegerRange(120, 220)


class Slide:
pass
def __init__(self, name: str,
limitation_class: SlideLimitationValidator) -> None:
self.name = name
self.limitation_class = limitation_class

def can_access(self, visitor: Visitor) -> bool:
try:
self.limitation_class(visitor.age, visitor.weight, visitor.height)
except (ValueError, TypeError):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you're creating an instance of the SlideLimitationValidator class (or its subclass), but you're not calling the validate method. It seems that the validate method should be called here to check if a visitor can access the slide.

return False
return True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The can_access method in the Slide class is not working as expected. It tries to create a new instance of SlideLimitationValidator (or its child classes) with visitor's parameters. But these classes don't validate anything during the initialization. I would suggest you to add a validation method in the SlideLimitationValidator class and call this method here.

Loading