-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solutionend #610
base: master
Are you sure you want to change the base?
solutionend #610
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,66 @@ | ||
from abc import ABC | ||
from typing import Any | ||
|
||
|
||
class IntegerRange: | ||
pass | ||
def __init__(self, min_amount: int, max_amount: int) -> None: | ||
self.min_amount = min_amount | ||
self.max_amount = max_amount | ||
|
||
def __set_name__(self, owner: Any, name: str) -> None: | ||
self.protected_name = "_" + name | ||
|
||
def __get__(self, instance: Any, owner: Any) -> Any: | ||
return getattr(instance, self.protected_name) | ||
|
||
def __set__(self, instance: Any, value: Any) -> None: | ||
if not isinstance(value, int): | ||
raise TypeError(f"{value} should be integer!") | ||
if not (self.min_amount <= value <= self.max_amount): | ||
raise ValueError(f"{value} should be between " | ||
f"{self.min_amount} and " | ||
f"{self.max_amount}") | ||
setattr(instance, self.protected_name, value) | ||
|
||
|
||
class Visitor: | ||
pass | ||
def __init__(self, name: str, age: int, weight: int, height: int) -> None: | ||
self.name = name | ||
self.age = age | ||
self.weight = weight | ||
self.height = height | ||
|
||
|
||
class SlideLimitationValidator(ABC): | ||
pass | ||
def __init__(self, age: int, weight: int, height: int) -> None: | ||
self.age = age | ||
self.weight = weight | ||
self.height = height | ||
Comment on lines
34
to
+38
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The SlideLimitationValidator class doesn't actually validate anything. It should have a method that takes a Visitor instance as a parameter and checks if the visitor meets the age, weight, and height restrictions. |
||
|
||
|
||
class ChildrenSlideLimitationValidator(SlideLimitationValidator): | ||
pass | ||
age = IntegerRange(4, 14) | ||
weight = IntegerRange(20, 50) | ||
height = IntegerRange(80, 120) | ||
|
||
|
||
class AdultSlideLimitationValidator(SlideLimitationValidator): | ||
pass | ||
age = IntegerRange(14, 60) | ||
weight = IntegerRange(50, 120) | ||
height = IntegerRange(120, 220) | ||
|
||
|
||
class Slide: | ||
pass | ||
def __init__(self, name: str, | ||
limitation_class: SlideLimitationValidator) -> None: | ||
self.name = name | ||
self.limitation_class = limitation_class | ||
|
||
def can_access(self, visitor: Visitor) -> bool: | ||
try: | ||
self.limitation_class(visitor.age, | ||
visitor.weight, | ||
visitor.height) | ||
except (ValueError, TypeError): | ||
return False | ||
return True | ||
Comment on lines
+59
to
+66
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The can_access method is not using the SlideLimitationValidator correctly. You are trying to instantiate the SlideLimitationValidator with the visitor's age, weight, and height, but the SlideLimitationValidator doesn't actually do anything with those parameters. Instead, you should be calling a method on the SlideLimitationValidator instance that checks if the visitor meets the restrictions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
SlideLimitationValidator
class is a bit confusing. It seems like it should be a class that validates the limitations for a slide. But in its current form, it's more like a data holder than a validator. You should consider adding a validation method in this class and use it in theSlide
class.