Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 47 additions & 6 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,25 +1,66 @@
from abc import ABC
from typing import Any


class IntegerRange:
pass
def __init__(self, min_amount: int, max_amount: int) -> None:
self.min_amount = min_amount
self.max_amount = max_amount

def __set_name__(self, owner: Any, name: str) -> None:
self.private_name = f"_{name}"

def __get__(self, instance: Any, owner: Any) -> int:
return getattr(instance, self.private_name)

def __set__(self, instance: Any, value: Any) -> None:
if not isinstance(value, int):
raise TypeError

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TypeError raised here lacks a descriptive message. Consider adding a message to indicate that the value must be an integer.


if value < self.min_amount or value > self.max_amount:
raise ValueError

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ValueError raised here lacks a descriptive message. Consider adding a message to indicate that the value must be within the specified range.


setattr(instance, self.private_name, value)


class Visitor:
pass
def __init__(self, name: str, age: int, weight: int, height: int) -> None:
self.name = name
self.age = age
self.weight = weight
self.height = height


class SlideLimitationValidator(ABC):
pass
def __init__(self, age: int, weight: int, height: int) -> None:
self.age = age
self.weight = weight
self.height = height


class ChildrenSlideLimitationValidator(SlideLimitationValidator):
pass
age = IntegerRange(4, 14)
height = IntegerRange(80, 120)
weight = IntegerRange(20, 50)


class AdultSlideLimitationValidator(SlideLimitationValidator):
pass
age = IntegerRange(14, 60)
height = IntegerRange(120, 220)
weight = IntegerRange(50, 120)


class Slide:
pass
def __init__(self,
name: str,
limitation_class: SlideLimitationValidator
) -> None:
self.name = name
self.limitation_class = limitation_class

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The limitation_class should be an instance of a validator class, not the class itself. Consider instantiating the validator class before assigning it to self.limitation_class.


def can_access(self, visitor: Visitor) -> bool:
try:
self.limitation_class(visitor.age, visitor.weight, visitor.height)
return True
except (TypeError, ValueError):
return False
Loading