-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #623
base: master
Are you sure you want to change the base?
solution #623
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,66 @@ | ||
from abc import ABC | ||
from typing import Any | ||
|
||
|
||
class IntegerRange: | ||
pass | ||
def __init__(self, min_amount: int, max_amount: int) -> None: | ||
self.min_amount = min_amount | ||
self.max_amount = max_amount | ||
|
||
def __set_name__(self, owner: Any, name: str) -> None: | ||
self.private_name = f"_{name}" | ||
|
||
def __get__(self, instance: Any, owner: Any) -> int: | ||
return getattr(instance, self.private_name) | ||
|
||
def __set__(self, instance: Any, value: Any) -> None: | ||
if not isinstance(value, int): | ||
raise TypeError | ||
|
||
if value < self.min_amount or value > self.max_amount: | ||
raise ValueError | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
|
||
setattr(instance, self.private_name, value) | ||
|
||
|
||
class Visitor: | ||
pass | ||
def __init__(self, name: str, age: int, weight: int, height: int) -> None: | ||
self.name = name | ||
self.age = age | ||
self.weight = weight | ||
self.height = height | ||
|
||
|
||
class SlideLimitationValidator(ABC): | ||
pass | ||
def __init__(self, age: int, weight: int, height: int) -> None: | ||
self.age = age | ||
self.weight = weight | ||
self.height = height | ||
|
||
|
||
class ChildrenSlideLimitationValidator(SlideLimitationValidator): | ||
pass | ||
age = IntegerRange(4, 14) | ||
height = IntegerRange(80, 120) | ||
weight = IntegerRange(20, 50) | ||
|
||
|
||
class AdultSlideLimitationValidator(SlideLimitationValidator): | ||
pass | ||
age = IntegerRange(14, 60) | ||
height = IntegerRange(120, 220) | ||
weight = IntegerRange(50, 120) | ||
|
||
|
||
class Slide: | ||
pass | ||
def __init__(self, | ||
name: str, | ||
limitation_class: SlideLimitationValidator | ||
) -> None: | ||
self.name = name | ||
self.limitation_class = limitation_class | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
|
||
def can_access(self, visitor: Visitor) -> bool: | ||
try: | ||
self.limitation_class(visitor.age, visitor.weight, visitor.height) | ||
return True | ||
except (TypeError, ValueError): | ||
return False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
TypeError
raised here lacks a descriptive message. Consider adding a message to indicate that the value must be an integer.