'Solution' #627
'Solution' #627
Conversation
There was a problem hiding this comment.
Great job on implementing the system for validating visitor access to slides! 🎉 While the code meets the task requirements, there are a couple of areas for improvement. Consider using the IntegerRange descriptors in the Visitor class to ensure consistent validation of attributes. Additionally, you might want to add abstract methods to the SlideLimitationValidator class to fully leverage the benefits of using an abstract base class. Keep up the good work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| self.name = name | ||
| self.age = age | ||
| self.weight = weight | ||
| self.height = height | ||
|
|
||
|
|
||
| class SlideLimitationValidator(ABC): |
There was a problem hiding this comment.
The SlideLimitationValidator class is intended to be an abstract class, but it does not define any abstract methods. Consider adding abstract methods to enforce implementation in subclasses.
| self.age = age | ||
| self.weight = weight | ||
| self.height = height |
There was a problem hiding this comment.
The Visitor class assigns values directly to age, weight, and height without using the IntegerRange descriptors. Consider using the descriptors to ensure that the values are validated upon assignment.
No description provided.