-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Solution' #1454
Open
shinodegu
wants to merge
2
commits into
mate-academy:master
Choose a base branch
from
shinodegu:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
'Solution' #1454
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
from app.people.customer import Customer | ||
|
||
|
||
class CinemaBar: | ||
@staticmethod | ||
def sell_product(customer: Customer, product: str) -> None: | ||
print(f"Cinema bar sold {product} to {customer.name}.") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
from app.people.cinema_staff import Cleaner | ||
|
||
|
||
class CinemaHall: | ||
def __init__(self, number: int) -> None: | ||
self.number = number | ||
|
||
def movie_session(self, movie_name: str, customers: list, | ||
cleaning_staff: Cleaner) -> None: | ||
print(f'"{movie_name}" started in hall number {self.number}.') | ||
for customer in customers: | ||
customer.watch_movie(movie=movie_name) | ||
print(f'"{movie_name}" ended.') | ||
cleaning_staff.clean_hall(self.number) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,17 @@ | ||
# write your imports here | ||
from app.cinema.bar import CinemaBar | ||
from app.cinema.hall import CinemaHall | ||
from app.people.cinema_staff import Cleaner | ||
from app.people.customer import Customer | ||
|
||
|
||
def cinema_visit(customers: list, hall_number: int, cleaner: str, movie: str): | ||
# write you code here | ||
pass | ||
def cinema_visit(customers: list, hall_number: int, | ||
cleaner: Cleaner, movie: str) -> None: | ||
customer_info = [Customer(name=cust["name"], | ||
food=cust["food"]) for cust in customers] | ||
for customer in customer_info: | ||
CinemaBar.sell_product(customer=customer, product=customer.food) | ||
hall = CinemaHall(hall_number) | ||
cleaner_name = Cleaner(cleaner) | ||
hall.movie_session(movie_name=movie, | ||
customers=customer_info, | ||
cleaning_staff=cleaner_name) |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
class Cleaner: | ||
def __init__(self, name: str) -> None: | ||
self.name = name | ||
|
||
def clean_hall(self, hall_number: int) -> None: | ||
print(f"Cleaner {self.name} is cleaning hall number {hall_number}.") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
class Customer: | ||
def __init__(self, name: str, food: str) -> None: | ||
self.name = name | ||
self.food = food | ||
|
||
def watch_movie(self, movie: str) -> None: | ||
print(f'{self.name} is watching "{movie}".') |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instantiation of
Cleaner
withCleaner(cleaner)
assumes thatCleaner
takes a single argument in its constructor. Verify that theCleaner
class is designed to be instantiated this way. IfCleaner
requires different arguments or initialization, adjust this line accordingly.