Solution #1302
Open
Solution #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Great job on implementing the Animal, Cat, and Dog classes, as well as the feed_animals function! 🎉 Your code meets the task requirements and constraints effectively. Just a small suggestion: update the function signature of feed_animals to -> int if you intend to return the total food consumed. Keep up the good work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
Comment on lines
+37
to
+39
| def feed_animals(animals: list[Animal]) -> None: | ||
| total_food = sum(animal.feed() for animal in animals) | ||
| return total_food |
There was a problem hiding this comment.
The function feed_animals is defined to return None, but it attempts to return total_food. If you intend to return the total food consumed, you should update the function signature to reflect this, changing -> None to -> int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.