Solution #426
Open
Solution #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenPidhoretskyi
suggested changes
Jul 18, 2023
main.py
Outdated
Comment on lines
17
to
20
| race = Race.objects.get_or_create( | ||
| name=race_.get("name"), | ||
| description=race_.get("description") | ||
| )[0] |
There was a problem hiding this comment.
Suggested change
| race = Race.objects.get_or_create( | |
| name=race_.get("name"), | |
| description=race_.get("description") | |
| )[0] | |
| race, _ = Race.objects.get_or_create( | |
| name=race_.get("name"), | |
| description=race_.get("description") | |
| ) |
Better to do like this)
Fix in all places
There was a problem hiding this comment.
It is more clear code. If you know that it will return tuple with two params better to use:
variable, _
In all future project you will use this construction instead of [0]
[0] you can use if there unknown count of parameters
main.py
Outdated
| email=email, | ||
| bio=bio, | ||
| guild=guild, | ||
| race_id=race.id |
There was a problem hiding this comment.
Suggested change
| race_id=race.id | |
| race=race |
Grayder0152
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.