Solution game-models #439
Open
Solution game-models #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimosphen1
suggested changes
Aug 3, 2023
main.py
Outdated
Comment on lines
51
to
52
| print(new_player) | ||
| print("---------------") |
There was a problem hiding this comment.
Delete these prints, they are not needed.
main.py
Outdated
| name=guild_name, | ||
| description=guild.get("description") | ||
| ) | ||
| guild_from_db = Guild.objects.get(name=guild_name) |
There was a problem hiding this comment.
There is no need to query the database additionally in case you create a record, .create() will return the required object. You need to write it to a variable. Execute .get() in the else statement to achieve that.
main.py
Outdated
Comment on lines
31
to
36
| if not Race.objects.filter(name=race_name).exists(): | ||
| Race.objects.create( | ||
| name=race_name, | ||
| description=race_.get("description") | ||
| ) | ||
| race_from_db = Race.objects.get(name=race_name) |
There was a problem hiding this comment.
There is no need to query the database additionally in case you create a record, .create() will return the required object. You need to write it to a variable. Execute .get() in the else statement to achieve that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.