Solution #452
Open
Solution #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenPidhoretskyi
suggested changes
Aug 22, 2023
main.py
Outdated
Comment on lines
13
to
14
| if not Race.objects.filter(name=race_name).exists(): | ||
| race = Race.objects.create( |
There was a problem hiding this comment.
Use get_or_create
https://docs.djangoproject.com/en/4.2/ref/models/querysets/#get-or-create
Fix in all places
ArsenPidhoretskyi
suggested changes
Aug 24, 2023
main.py
Outdated
| description=player_attributes["race"]["description"] | ||
| ) | ||
| if created: | ||
| for skill in player_attributes["race"].get("skills"): |
There was a problem hiding this comment.
Suggested change
| for skill in player_attributes["race"].get("skills"): | |
| for skill in player_attributes["race"].get("skills", []): |
Possible error if not use default attribute
main.py
Outdated
Comment on lines
24
to
30
| if player_attributes.get("guild"): | ||
| guild, created = Guild.objects.get_or_create( | ||
| name=player_attributes["guild"]["name"], | ||
| description=player_attributes["guild"]["description"] | ||
| ) | ||
| else: | ||
| guild = None |
There was a problem hiding this comment.
Suggested change
| if player_attributes.get("guild"): | |
| guild, created = Guild.objects.get_or_create( | |
| name=player_attributes["guild"]["name"], | |
| description=player_attributes["guild"]["description"] | |
| ) | |
| else: | |
| guild = None | |
| guild = None | |
| if player_attributes.get("guild"): | |
| guild, created = Guild.objects.get_or_create( | |
| name=player_attributes["guild"]["name"], | |
| description=player_attributes["guild"]["description"] | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.