Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #457

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Solution #457

wants to merge 12 commits into from

Conversation

ilizh
Copy link

@ilizh ilizh commented Aug 26, 2023

No description provided.

Copy link

@Bohdan-Salamakha Bohdan-Salamakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix tests

main.py Outdated
data = json.load(json_file)

for player_name, entry in data.items():
race_data = entry["race"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use .get() method instead of key access

@ilizh ilizh requested a review from olena-hul August 29, 2023 11:00
Copy link

@YukihiroSM YukihiroSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants