Develop #341
Open
Develop #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bohdan-Salamakha
suggested changes
Aug 5, 2023
app/customer.py
Outdated
| money: int, | ||
| car: Car, | ||
| product_cart: dict, | ||
| customer_location: list |
There was a problem hiding this comment.
add additional typehint for list inner objects like list[YOUR_VALUE_TYPE]
for example: list that contains string elements has typehint list[str]
app/customer.py
Outdated
| products_price = self.get_product_price(shop) | ||
| return round(fuel_cost + products_price, 2) | ||
|
|
||
| def get_product_price(self, shop: Shop) -> None: |
app/customer.py
Outdated
Comment on lines
50
to
54
| def products_cost(self, product_cart: dict) -> int: | ||
| total = 0 | ||
| for product in product_cart: | ||
| total += self.product_cart[product] | ||
| return total |
There was a problem hiding this comment.
remove this non-callable method
app/customer.py
Outdated
| + (shop.location[1] - self.location[1]) ** 2) ** 0.5 | ||
| ) | ||
|
|
||
| fuel_cost = \ |
There was a problem hiding this comment.
use parentheses instead of backslash to wrap the line
app/main.py
Outdated
Comment on lines
60
to
61
| # if __name__ == "__main__": | ||
| # shop_trip() |
app/shop.py
Outdated
|
|
||
| class Shop: | ||
|
|
||
| def __init__(self, name: str, shop_location: list, products: dict) -> None: |
There was a problem hiding this comment.
add additional typehint for list inner objects like list[YOUR_VALUE_TYPE]
for example: list that contains string elements has typehint list[str]
Bohdan-Salamakha
suggested changes
Aug 5, 2023
app/main.py
Outdated
Comment on lines
7
to
57
| def shop_trip() -> None: | ||
| with open("app/config.json") as file: | ||
| config = json.load(file) | ||
|
|
||
| fuel_price = config["FUEL_PRICE"] | ||
|
|
||
| customers = [ | ||
| Customer(name=customer["name"], | ||
| product_cart=customer["product_cart"], | ||
| customer_location=customer["location"], | ||
| money=customer["money"], | ||
| car=Car(**customer["car"])) | ||
| for customer in config["customers"] | ||
| ] | ||
|
|
||
| shops = [ | ||
| Shop(name=shop["name"], | ||
| shop_location=shop["location"], | ||
| products=shop["products"]) | ||
| for shop in config["shops"] | ||
| ] | ||
| for customer in customers: | ||
| cheapest_cost = None | ||
| cheapest_shop = None | ||
| print(f"{customer.name} has {customer.money} dollars") | ||
| for shop in shops: | ||
|
|
||
| trip_cost = customer.get_trip_price(fuel_price, shop) | ||
|
|
||
| print(f"{customer.name}\'s trip to the " | ||
| f"{shop.name} costs {trip_cost}") | ||
|
|
||
| if cheapest_cost is None or trip_cost < cheapest_cost: | ||
| cheapest_cost = trip_cost | ||
| cheapest_shop = shop | ||
|
|
||
| if customer.money >= cheapest_cost: | ||
| print(f"{customer.name} rides to {cheapest_shop.name}") | ||
| customer.location = cheapest_shop.location | ||
| customer.money -= cheapest_cost | ||
|
|
||
| customer.print_the_purchase_receipt(cheapest_shop) | ||
| print(f"Total cost is " | ||
| f"{customer.get_product_price(cheapest_shop)} dollars") | ||
| print("See you again!\n") | ||
|
|
||
| print(f"{customer.name} rides home") | ||
| print(f"{customer.name} now has {customer.money} dollars\n") | ||
| else: | ||
| print(f"{customer.name} doesn't have enough money " | ||
| f"to make a purchase in any shop") |
There was a problem hiding this comment.
separate your function into a few functions with own logic
app/shop.py
Outdated
Comment on lines
5
to
9
| def __init__(self, | ||
| name: str, | ||
| shop_location: list[int, int], | ||
| products: dict | ||
| ) -> None: |
There was a problem hiding this comment.
Suggested change
| def __init__(self, | |
| name: str, | |
| shop_location: list[int, int], | |
| products: dict | |
| ) -> None: | |
| def __init__( | |
| self, | |
| name: str, | |
| shop_location: list[int, int], | |
| products: dict | |
| ) -> None: | |
Bohdan-Salamakha
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.