created shop trip func #589
Conversation
| with open("app/config.json", "r") as file_info: | ||
| all_info = json.load(file_info) |
There was a problem hiding this comment.
Do not overload a context manage, perform only load operation within it.
app/main.py
Outdated
| cost_for_trip = round( | ||
| 2 * customer.car.calculate_trip_cost( | ||
| customer.car.calculate_distance( | ||
| customer.location, | ||
| shop.location | ||
| ), | ||
| fuel_price | ||
| ) | ||
| + shop.calculate_cost_for_products(customer.product_cart) | ||
| , 2) |
There was a problem hiding this comment.
In case there are no arguments on the same line with an opening parenthesis, your closing parenthesis should not have any arguments on the same line as well. Please, resolve this issue
app/main.py
Outdated
| f"doesn't have enough money to make a purchase in any shop") | ||
| else: | ||
| chippest_shop = list(costs_for_trips.keys())[ | ||
| list(costs_for_trips.values()).index( |
There was a problem hiding this comment.
Leave no arguments for closing parenthesis as it is don for an opening one
app/shops.py
Outdated
| total_sum = 0 | ||
| for product in product_cart: | ||
| total_sum += product_cart[product] * self.products[product] | ||
|
|
||
| return total_sum |
There was a problem hiding this comment.
You could use sum and generator expression here
app/config.json
Outdated
| @@ -73,4 +73,4 @@ | |||
| } | |||
| } | |||
| ] | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Add a blank line at the end of the file here
app/main.py
Outdated
| print(f"{customer.name} " | ||
| f"doesn't have enough money to make a purchase in any shop") | ||
| else: | ||
| chippest_shop = list(costs_for_trips.keys())[ |
There was a problem hiding this comment.
Please find another, simple way to find chippest_shop
Maybe you can do it during iteration over list_of_shops
| f"now has {customer.money} dollars\n") | ||
|
|
||
|
|
||
| shop_trip() |
There was a problem hiding this comment.
Place the function calls in the file inside of the if __name__ == "__main__" block in the future
No description provided.