The solution of the task #597
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlopro
suggested changes
Jul 15, 2024
app/main.py
Outdated
| def shop_trip() -> None: | ||
| with open("app/config.json", "r") as f: | ||
| data = json.load(f) | ||
| fuel_price = data["FUEL_PRICE"] |
There was a problem hiding this comment.
Do not overload context manager
Start retrieving data outside context manager
app/main.py
Outdated
| people["car"]["fuel_consumption"]) | ||
| ) | ||
| print(f"{customer.name} has {customer.money} dollars") | ||
| prices = [] |
There was a problem hiding this comment.
from task requirements:
When the customer arrives at the shop his location should equal to shop location. After the shop he arrives home and counts the remaining money.
vsmutok
suggested changes
Jul 22, 2024
app/main.py
Outdated
Comment on lines
21
to
22
| Car(people["car"]["brand"], | ||
| people["car"]["fuel_consumption"]) |
There was a problem hiding this comment.
Suggested change
| Car(people["car"]["brand"], | |
| people["car"]["fuel_consumption"]) | |
| Car(**people["car"]) |
you can use unpacking in this case
app/main.py
Outdated
Comment on lines
27
to
28
| distance = math.dist(customer.location, shop.location) | ||
| cost = round(shop.trip_cost(distance, fuel_price, customer), 2) |
app/main.py
Outdated
Comment on lines
38
to
43
| distance = math.dist(customer.location, current_shop.location) | ||
| current_shop.print_receipt(customer) | ||
| print(f"{customer.name} rides home") | ||
| customer.money -= round( | ||
| current_shop.trip_cost(distance, fuel_price, customer), 2 | ||
| ) |
There was a problem hiding this comment.
DRY
you are double counting the distance and price of products for the same store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.