Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #599

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

solution #599

wants to merge 14 commits into from

Conversation

midetc
Copy link

@midetc midetc commented Jul 18, 2024

No description provided.

Copy link

@EdAlekseiev EdAlekseiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix flake8 errors, please

app/main.py Outdated

print(f"{customer.name} rides to {best_shop.name}\n")
customer.make_purchase(best_shop, fuel_price)
print(f"Date: {datetime(2021, 1, 4, 12, 33, 41).strftime(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use datetime.now instead of hardcode

@midetc midetc requested a review from EdAlekseiev July 18, 2024 21:02
Copy link
Contributor

@vsmutok vsmutok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests Failed!

@midetc midetc requested a review from vsmutok July 20, 2024 08:30
app/shop.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
app/customer.py Outdated
Comment on lines 21 to 23
return sum([shop.get_product_price(product)
* quantity for product, quantity
in self.product_cart.items()])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return sum([shop.get_product_price(product)
* quantity for product, quantity
in self.product_cart.items()])
return sum(
shop.get_product_price(product) * quantity for product, quantity
in self.product_cart.items()
)

@midetc midetc requested a review from vsmutok July 22, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants