implemented "Shop trip" behaviour #600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oleksl888
suggested changes
Aug 29, 2024
app/main.py
Outdated
|
|
||
|
|
||
| def init_shops(data: list) -> list[Shop]: | ||
| result_list = [] |
app/main.py
Outdated
| def shop_trip() -> None: | ||
| data = get_data_from_json() | ||
| fuel_price = data["FUEL_PRICE"] | ||
| customers = init_customers(data["customers"]) |
There was a problem hiding this comment.
you can optimize your code so you don't have to iterate over the same data twice. You can basically create customer and do all the trip related actions in one loop
app/customer.py
Outdated
|
|
||
| def calculate_trip_cost(self, shop: Shop, fuel_price: float) -> float: | ||
| distance_to_shop_and_home = sqrt( | ||
| (shop.location[0] - self.location[0]) ** 2 |
There was a problem hiding this comment.
You could create class Location with method that calculates distance between two points to better structure your code
app/customer.py
Outdated
| (shop.location[0] - self.location[0]) ** 2 | ||
| + (shop.location[1] - self.location[1]) ** 2) | ||
|
|
||
| fuel_cost_to_shop_and_home = (distance_to_shop_and_home |
app/customer.py
Outdated
| * (self.car.fuel_consumption / 100) | ||
| * fuel_price) | ||
|
|
||
| product_cost_total = sum(shop.products[key] * value |
There was a problem hiding this comment.
This could be a method defined in Shop
app/main.py
Outdated
| f" money to make a purchase in any shop") | ||
| return | ||
|
|
||
| print(f"{customer.name} rides to {current_shop.name}") |
There was a problem hiding this comment.
you can put all this prints as a method in your Customer class - this way you will offload a bunch of code from your main function and make it cleaner
app/customer.py
Outdated
| def buy_products(self, current_shop: Shop) -> float: | ||
| total_cost = 0 | ||
| for key, value in self.product_cart.items(): | ||
| for _ in range(3): |
app/customer.py
Outdated
| for key, value in self.product_cart.items(): | ||
| for _ in range(3): | ||
| cost = current_shop.products[key] * value | ||
| if ".0" in str(cost): |
There was a problem hiding this comment.
save cost using ternary operator and then pass it to print only once like so:
product_cost = ... if something else ...
print(f"{value} {key}s for {product_cost} dollars")
…o shop, customer, car
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.