Solution #1187
Open
Solution #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdAlekseiev
suggested changes
Sep 19, 2024
app/main.py
Outdated
| @@ -1 +1,58 @@ | |||
| # write your code here | |||
| class SoftwareEngineer: | |||
| skills = [] | |||
There was a problem hiding this comment.
skills is mutable object (a list), is shared among all instances and subclasses, leading to unpredictable behavior when its contents are modified. This means that adding skills in one instance can affect all others that inherit from this class. You should move skills to an instance-level variable within the constructor, ensuring each instance has its own separate list of skills.
vsmutok
suggested changes
Sep 20, 2024
app/main.py
Outdated
Comment on lines
46
to
51
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) | ||
| self.skills = ( | ||
| BackendDeveloper(self.name).skills | ||
| + FrontendDeveloper(self.name).skills | ||
| ) |
app/main.py
Outdated
| class FrontendDeveloper(SoftwareEngineer): | ||
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) | ||
| self.skills = ["JavaScript", "HTML", "CSS"] |
There was a problem hiding this comment.
Suggested change
| self.skills = ["JavaScript", "HTML", "CSS"] | |
| self.skills += ["JavaScript", "HTML", "CSS"] |
Don't override skills, but updated them.
EdAlekseiev
suggested changes
Sep 20, 2024
app/main.py
Outdated
| class FrontendDeveloper(SoftwareEngineer): | ||
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) | ||
| self.skills = ["JavaScript", "HTML", "CSS"] |
app/main.py
Outdated
Comment on lines
46
to
48
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) | ||
| self.skills += ["JavaScript", "HTML", "CSS"] |
vsmutok
suggested changes
Sep 21, 2024
app/main.py
Outdated
Comment on lines
46
to
47
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) |
app/main.py
Outdated
Comment on lines
54
to
56
|
|
||
| ben = FullStackDeveloper("Ben") | ||
| print(ben.skills) |
vasylhnatiuk
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.