Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #1188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1188

wants to merge 1 commit into from

Conversation

KKvladys
Copy link

No description provided.

dmytrik
dmytrik approved these changes Sep 21, 2024
View reviewed changes
Copy link

@dmytrik dmytrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-21 at 19 17 01 checklist reccomend us use extend or += [skills] :) but in common i think very good

@Nattalli
Copy link
Contributor

Screenshot 2024-09-21 at 19 17 01 checklist reccomend us use extend or += [skills] :) but in common i think very good

well, the checklist tells that you better add new skills (when there are a list of them) avoiding loop and append method. But in this method you are adding only one skill so you have not use a loop. So that solution is pretty good 😸

Nattalli
Nattalli approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@Nattalli Nattalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nattalli Nattalli Nattalli approved these changes

@dmytrik dmytrik dmytrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KKvladys @Nattalli @dmytrik