Solution #1200
Solution #1200
Conversation
| def __init__(self, name: str) -> None: | ||
| self.name = name | ||
| self.skills: list[str] = [] | ||
|
|
||
| def learn_skill(self, skill: str) -> None: | ||
| if skill not in self.skills: | ||
| self.skills.append(skill) |
There was a problem hiding this comment.
you can not use if in learn_skill method, if you have created list in the __init__ method, because you already have this list
There was a problem hiding this comment.
Method __init__ creates an empty list for storing skills.
The learn_skill method adds a new skill, but first checks if the list already contains this skill to avoid duplicates.
So, in my opinion, the verification is important.
| class FrontendDeveloper(SoftwareEngineer): | ||
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) | ||
| self.skills.extend(["JavaScript", "HTML", "CSS"]) |
There was a problem hiding this comment.
I guess, if you pass only name to patent class, you don't have skills attribute in the current instanse , and i think, you can write like this: self.skills = ["JavaScript", "HTML", "CSS"]
it is created skills attribute in this instance
and the same in other classes
There was a problem hiding this comment.
The self.skills attribute is already initialized as an empty list in the parent SoftwareEngineer class when the __init__ method is called. In child classes, such as FrontendDeveloper, there is no need to create it again.
The use of self.skills.extend(...) in child classes is correct because it simply extends the existing list of skills inherited from the parent class.
In other words, when you create an instance of the FrontendDeveloper class, the skills attribute will be a copy of the skills list inherited from the parent class, but it will be unique for each instance.
| class BackendDeveloper(SoftwareEngineer): | ||
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) | ||
| self.skills.extend(["Python", "SQL", "Django"]) |
| class AndroidDeveloper(SoftwareEngineer): | ||
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) | ||
| self.skills.extend(["Java", "Android studio"]) |
No description provided.