'Solution' #1206
'Solution' #1206
Conversation
There was a problem hiding this comment.
I think good job!
But if you will use:
self.skills.extend([skill])
instead of:
self.skills.append(skill)
and
self.skills.extend(["JavaScript", "HTML", "CSS"])
insted of:
self.skills = ["JavaScript", "HTML", "CSS"]
and so on it other clesses.
I think it will better!
And then you don't need init() method in FullStackDeveloper class.
|
|
||
|
|
||
| class FullStackDeveloper(BackendDeveloper, FrontendDeveloper): | ||
| def __init__(self, name: str) -> None: |
There was a problem hiding this comment.
if you will use
self.skills.extend(["skill_one", "skill_two", "skill_three"])
in classes above
you don't need
__init__ ()
|
|
||
| class FullStackDeveloper(BackendDeveloper, FrontendDeveloper): | ||
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) |
There was a problem hiding this comment.
You are inheriting from both BackendDeveloper and FrontendDeveloper. Since both classes are children of SoftwareEngineer, Python's method resolution order (MRO) will only call the init method from the first parent class (BackendDeveloper).
This means the FrontendDeveloper's skills won't be initialized unless you call the init of both parents explicitly.
There was a problem hiding this comment.
I agree with you!
But it work without init() method
I think it is because when we use method self.create_awesome_web_page() that inherited from Frontend Developer it will run init() method from FrontendDeveloper.
I mean that if we don't use init method for FullStackDeveloper,
self.create_powerful_api() will use BackendDeveloper init method,
self.create_awesome_web_page() will use FrontendDeveloper init method.
No description provided.