'Solution' #1212
Open
'Solution' #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nattalli
suggested changes
Oct 7, 2024
app/main.py
Outdated
Comment on lines
42
to
44
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) | ||
| self.skills = list(set(self.skills + BackendDeveloper(name).skills)) |
There was a problem hiding this comment.
read checklist, you don't need to overwrite that method if it's already inplemented in parent classes (but you should provide adding skills there) and fullstack developer skills is frontend developer skills + backend developer skills
app/main.py
Outdated
| class AndroidDeveloper(SoftwareEngineer): | ||
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) | ||
| self.skills = ["Java", "Android studio"] |
There was a problem hiding this comment.
that should extend list of skills from SoftwareEngineer class
Arsen-hrynevych
approved these changes
Oct 8, 2024
| class SoftwareEngineer: | ||
| def __init__(self, name: str) -> None: | ||
| self.name = name | ||
|
|
There was a problem hiding this comment.
remove blank line here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.