Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #1238

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #1238

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed4a8e0
Solution
Koliesnichenko Oct 11, 2024
8859759
Solution2
Koliesnichenko Oct 11, 2024
c92c488
Solution3
Koliesnichenko Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 44 additions & 1 deletion app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,44 @@
# write your code here
class SoftwareEngineer:
def __init__(self, name: str) -> None:
self.name = name
self.skills = []

def learn_skill(self, skill: str) -> None:
self.skills.append(skill)

Comment on lines +6 to +7
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist, you should use the extend() method or += operator to add multiple values to a single list. You can replace append() with extend() or += and provide a list with a single element. This will make your code more consistent and easier to maintain.


class FrontendDeveloper(SoftwareEngineer):
def __init__(self, name: str) -> None:
super().__init__(name)
self.skills += ["JavaScript", "HTML", "CSS"]

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist point 1: Instead of using += operator to add multiple values to the skills list, you should use the extend() method. This would make your code more aligned with the Python best practices. Here is how you can do it: self.skills.extend(["JavaScript", "HTML", "CSS"])

def create_awesome_web_page(self) -> str:
print(f"{self.name} is creating a webpage...")
return "<h1>Hello world</h1>"


class BackendDeveloper(SoftwareEngineer):
def __init__(self, name: str) -> None:
super().__init__(name)
self.skills += ["Python", "SQL", "Django"]

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist point 1: Instead of using += operator to add multiple values to the skills list, you should use the extend() method. This would make your code more aligned with the Python best practices. Here is how you can do it: self.skills.extend(["Python", "SQL", "Django"])

def create_powerful_api(self) -> str:
print(f"{self.name} is creating an API...")
return "http://127.0.0.1:8000"


class AndroidDeveloper(SoftwareEngineer):
def __init__(self, name: str) -> None:
super().__init__(name)
self.skills += ["Java" , "Android studio"]

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist point 1: Instead of using += operator to add multiple values to the skills list, you should use the extend() method. This would make your code more aligned with the Python best practices. Here is how you can do it: self.skills.extend(["Java" , "Android studio"])

def create_smooth_mobile_app(self) -> str:
print(f"{self.name} is creating a mobile app...")
return "Ads every three swipes"


class FullStackDeveloper(FrontendDeveloper, BackendDeveloper):
def create_web_application(self) -> None:
print(f"{self.name} started creating a web application...")
self.create_powerful_api()
self.create_awesome_web_page()
Loading