Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution_ver-1 #1248

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KhrypunovMaxim
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the code! While there's a suggestion to use extend() or += for adding multiple skills, it's a minor improvement and doesn't impact the functionality. Keep up the good work and consider this tip for future enhancements! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

app/main.py Outdated
Comment on lines 15 to 17
super().learn_skill("JavaScript")
super().learn_skill("HTML")
super().learn_skill("CSS")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the extend() method or += operator to add multiple skills to the skills list at once, as per the checklist requirement.

app/main.py Outdated
Comment on lines 28 to 30
super().learn_skill("Python")
super().learn_skill("SQL")
super().learn_skill("Django")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the extend() method or += operator to add multiple skills to the skills list at once, as per the checklist requirement.

app/main.py Outdated
Comment on lines 41 to 42
super().learn_skill("Java")
super().learn_skill("Android studio")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the extend() method or += operator to add multiple skills to the skills list at once, as per the checklist requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants