Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1256

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #1256

wants to merge 2 commits into from

Conversation

Waldemar-wal
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the class hierarchy for different types of software engineers! 🎉 Your code meets the task requirements and constraints effectively. However, there's a minor issue with the method resolution order (MRO) in the FullStackDeveloper class. To ensure all skills are initialized correctly, consider adjusting the order of inheritance or explicitly calling the __init__ methods of both parent classes. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

app/main.py Show resolved Hide resolved
@Waldemar-wal Waldemar-wal marked this pull request as draft October 30, 2024 09:04
@Waldemar-wal Waldemar-wal marked this pull request as ready for review October 30, 2024 09:06
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the class hierarchy for different types of software engineers! 🎉 Your code meets the task requirements and constraints effectively. While the method resolution order (MRO) in the FullStackDeveloper class could potentially lead to unexpected behavior, it doesn't critically impact the functionality or security of your code. Just be mindful of this in future projects to ensure clarity and avoid ambiguity. Keep up the excellent work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

return "Ads every three swipes"


class FullStackDeveloper(BackendDeveloper, FrontendDeveloper):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FullStackDeveloper class inherits from both BackendDeveloper and FrontendDeveloper. In Python, the method resolution order (MRO) follows the C3 linearization algorithm, which means that the BackendDeveloper's methods will be prioritized over FrontendDeveloper's methods. This might lead to unexpected behavior if both parent classes have methods with the same name. Ensure that this is the intended behavior or consider using explicit method calls to avoid ambiguity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants