-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #1256
base: master
Are you sure you want to change the base?
Develop #1256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the class hierarchy for different types of software engineers! 🎉 Your code meets the task requirements and constraints effectively. However, there's a minor issue with the method resolution order (MRO) in the FullStackDeveloper
class. To ensure all skills are initialized correctly, consider adjusting the order of inheritance or explicitly calling the __init__
methods of both parent classes. Keep up the good work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the class hierarchy for different types of software engineers! 🎉 Your code meets the task requirements and constraints effectively. While the method resolution order (MRO) in the FullStackDeveloper
class could potentially lead to unexpected behavior, it doesn't critically impact the functionality or security of your code. Just be mindful of this in future projects to ensure clarity and avoid ambiguity. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
return "Ads every three swipes" | ||
|
||
|
||
class FullStackDeveloper(BackendDeveloper, FrontendDeveloper): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FullStackDeveloper
class inherits from both BackendDeveloper
and FrontendDeveloper
. In Python, the method resolution order (MRO) follows the C3 linearization algorithm, which means that the BackendDeveloper
's methods will be prioritized over FrontendDeveloper
's methods. This might lead to unexpected behavior if both parent classes have methods with the same name. Ensure that this is the intended behavior or consider using explicit method calls to avoid ambiguity.
No description provided.