Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #1260

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 60 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,60 @@
# write your code here
from __future__ import annotations


class SoftwareEngineer:

def __init__(self, name: str) -> None:
self.name = name
self.skills = []

def learn_skill(self, skill: str) -> None:
if skill not in self.skills:
self.skills.append(skill)


class FrontendDeveloper(SoftwareEngineer):

def __init__(self, name: str) -> None:
super().__init__(name)
self.skills = ["JavaScript", "HTML", "CSS"]

def create_awesome_web_page(self) -> str:
print(f"{self.name} is creating a webpage...")
return "<h1>Hello world</h1>"


class BackendDeveloper(SoftwareEngineer):

def __init__(self, name: str) -> None:
super().__init__(name)
self.skills = ["Python", "SQL", "Django"]

def create_powerful_api(self) -> str:
print(f"{self.name} is creating an API...")
return "http://127.0.0.1:8000"


class AndroidDeveloper(SoftwareEngineer):

def __init__(self, name: str) -> None:
super().__init__(name)
self.skills = ["Java", "Android studio"]

def create_smooth_mobile_app(self) -> str:
print(f"{self.name} is creating a mobile app...")
return "Ads every three swipes"


class FullStackDeveloper(BackendDeveloper, FrontendDeveloper):

def __init__(self, name: str) -> None:
BackendDeveloper.__init__(self, name)
FrontendDeveloper.__init__(self, name)
self.back_skills = BackendDeveloper(name).skills
Comment on lines +51 to +52

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constructor calls for BackendDeveloper and FrontendDeveloper are redundant. In Python, when using multiple inheritance, you should call super().__init__(name) once to ensure proper initialization. This will call the __init__ method of both parent classes in the correct order.

self.front_skills = FrontendDeveloper(name).skills
self.skills = self.back_skills + self.front_skills

Comment on lines +53 to +55

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way skills are being assigned here is not optimal. Instead of creating new instances of BackendDeveloper and FrontendDeveloper, you should directly use the skills from the current instance. Consider using self.skills = BackendDeveloper.skills + FrontendDeveloper.skills to avoid unnecessary object creation.

def create_web_application(self) -> None:
print(f"{self.name} started creating a web application...")
self.create_powerful_api()
self.create_awesome_web_page()
Loading