Solution_v1_MK #1262
Solution_v1_MK #1262
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this task! 😊 While your implementation is mostly correct and meets the task requirements, there's a critical issue that needs to be addressed before we can approve the Pull Request.
In the FullStackDeveloper class, the methods create_powerful_api and create_awesome_web_page are called before they are defined. This will lead to a runtime error when create_web_application is executed. To resolve this, please ensure these methods are properly defined within the class before they are called.
Once this issue is fixed, your code should be good to go! Keep up the great work, and don't hesitate to reach out if you need any help. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
app/main.py
Outdated
| def create_web_application(self) -> None: | ||
| print(f"{self.name} started creating a web application...") | ||
| self.create_powerful_api() | ||
| self.create_awesome_web_page() |
There was a problem hiding this comment.
The methods create_powerful_api and create_awesome_web_page are called before they are defined in the FullStackDeveloper class. This will result in a runtime error. Consider defining these methods before calling them in create_web_application.
There was a problem hiding this comment.
Great job on implementing the class hierarchy for different types of software engineers! 🎉 Your code is well-structured and meets the task requirements. Just a small suggestion: consider changing 'Android studio' to 'Android Studio' for consistency with naming conventions. This will help maintain a professional standard in your code. Keep up the good work, and remember to review the comments to further improve your skills. Happy coding! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| class AndroidDeveloper(SoftwareEngineer): | ||
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) | ||
| self.skills.extend(["Java", "Android studio"]) |
There was a problem hiding this comment.
Consider changing 'Android studio' to 'Android Studio' to maintain consistency with proper naming conventions.
No description provided.