Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #587

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

'Solution' #587

wants to merge 3 commits into from

Conversation

grungezz
Copy link

No description provided.

Copy link

@Kroll410 Kroll410 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, update one change

app/main.py Outdated
class FrontendDeveloper(SoftwareEngineer):
def __init__(self, name: str) -> None:
super().__init__(name)
self.learn_skill("JavaScript")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use for loops or extend method

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here and after

@grungezz grungezz requested a review from Kroll410 August 15, 2023 18:39
app/main.py Outdated
Comment on lines 41 to 42
def __init__(self, name: str) -> None:
super().__init__(name)
Copy link

@Serhii-Leonenko Serhii-Leonenko Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need init here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants