Solution #606
Open
Solution #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bohdan-Salamakha
suggested changes
Aug 30, 2023
app/main.py
Outdated
Comment on lines
49
to
52
| skills = BackendDeveloper.skills + FrontendDeveloper.skills | ||
|
|
||
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) |
There was a problem hiding this comment.
don't hardcode skills
+
u don't need an init method here
app/main.py
Outdated
Comment on lines
37
to
40
| skills = ["Java", "Android studio"] | ||
|
|
||
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) |
There was a problem hiding this comment.
u need to extend developer's skills list using extend() method or =+
app/main.py
Outdated
Comment on lines
13
to
16
| skills = ["JavaScript", "HTML", "CSS"] | ||
|
|
||
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) |
There was a problem hiding this comment.
u need to extend developer's skills list using extend() method or =+
app/main.py
Outdated
Comment on lines
25
to
28
| skills = ["Python", "SQL", "Django"] | ||
|
|
||
| def __init__(self, name: str) -> None: | ||
| super().__init__(name) |
There was a problem hiding this comment.
u need to extend developer's skills list using extend() method or =+
Bohdan-Salamakha
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.