fixed as per PR

mate-academy · Sep 26, 2024 · b34fe4c · b34fe4c
1 parent 10c268d
commit b34fe4c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/components/CommentList.tsx b/src/components/CommentList.tsx
@@ -9,7 +9,7 @@ type Props = {
 export const CommentList: React.FC<Props> = ({ comments, onDelete }) => {
   return (
     <>
-      {comments && comments.length > 0 ? (
+      {comments.length > 0 ? (
         comments.map(comment => {
           return (
             <CommentObj

diff --git a/src/components/UserSelector.tsx b/src/components/UserSelector.tsx
@@ -10,13 +10,13 @@ type Props = {
 export const UserSelector: React.FC<Props> = ({ users, onSelect }) => {
   // region States
   const [userSelect, setUserSelect] = useState<User | null>(null);
-  const [visibleList, setVisibleList] = useState(false);
+  const [visible, setVisible] = useState(false);
   //endregion
 
   // region Event handlers
   const handleUserSelect = (user: User): void => {
     setUserSelect(user);
-    setVisibleList(false);
+    setVisible(false);
     onSelect(user);
   };
   //endregion
@@ -29,7 +29,7 @@ export const UserSelector: React.FC<Props> = ({ users, onSelect }) => {
           className="button"
           aria-haspopup="true"
           aria-controls="dropdown-menu"
-          onClick={() => setVisibleList(prev => !prev)}
+          onClick={() => setVisible(prev => !prev)}
         >
           <span>{userSelect ? userSelect.name : 'Choose a user'}</span>
 
@@ -39,7 +39,7 @@ export const UserSelector: React.FC<Props> = ({ users, onSelect }) => {
         </button>
       </div>
 
-      {visibleList && (
+      {visible && (
         <div className="dropdown-menu" id="dropdown-menu" role="menu">
           <div className="dropdown-content">
             {users.map(user => {