Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #1150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #1150

wants to merge 2 commits into from

Conversation

dima91020
Copy link

No description provided.

@dima91020
Copy link
Author

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code
If you add only spaces, then the loader rotates constantly and nothing happens, this needs to be fixed
image

Add a correct type to input of email
image

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

const handleLoadComments = useCallback(
async (postId: number) => {
setIsLoadingComments(true);
// setIsError(false);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// setIsError(false);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants