Develop #1153
Open
Develop #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Aug 18, 2024
src/App.tsx
Outdated
| setIsLoading(true); | ||
| setPostLoadingFail(false); | ||
| getPosts(selectedUser.id) | ||
| .then(data => setPosts(data)) |
There was a problem hiding this comment.
Suggested change
| .then(data => setPosts(data)) | |
| .then(setPosts) |
src/App.tsx
Outdated
| }, [selectedUser]); | ||
|
|
||
| const showPostTost = | ||
| posts.length === 0 && !isLoading && selectedUser && !postLoadingFail; |
There was a problem hiding this comment.
Suggested change
| posts.length === 0 && !isLoading && selectedUser && !postLoadingFail; | |
| !posts.length && !isLoading && selectedUser && !postLoadingFail; |
src/App.tsx
Outdated
|
|
||
| <PostsList /> | ||
| {posts.length > 0 && !isLoading && ( |
There was a problem hiding this comment.
Suggested change
| {posts.length > 0 && !isLoading && ( | |
| {!!posts.length && !isLoading && ( |
src/components/PostDetails.tsx
Outdated
| </button> | ||
| </div> | ||
| deleteComment(commentId).catch(() => { | ||
| // Опционально: можно добавить обработку ошибок для восстановления удалённого комментария |
There was a problem hiding this comment.
I`m use chatgpt because i want to better understand how writing nice code and logic. However i know than it bad practice. maybe)
src/components/PostDetails.tsx
Outdated
| > | ||
| <div className="message-header"> | ||
| <a href={`mailto:${comment.email}`} data-cy="CommentAuthor"> | ||
| {comment.name} |
There was a problem hiding this comment.
Use destructuring for comment
src/components/PostDetails.tsx
Outdated
| delete button | ||
| </button> | ||
| </div> | ||
| {!isLoading && !isError && comments.length === 0 && ( |
There was a problem hiding this comment.
Suggested change
| {!isLoading && !isError && comments.length === 0 && ( | |
| {!isLoading && !isError && !comments.length && ( |
src/components/UserSelector.tsx
Outdated
Comment on lines
64
to
68
| onClick={() => { | ||
| setSelectedUserState(user); | ||
| setDropdownOpen(false); | ||
| setSelectedUser(user); | ||
| }} |
There was a problem hiding this comment.
Move this logic from jsx to the helper function and use it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO