Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #1176

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #1176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85b7e1e
Solution
RostyslavSharuiev Oct 11, 2024
1e2d1dc
Fixes
RostyslavSharuiev Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 99 additions & 41 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,60 +1,118 @@
import classNames from 'classnames';
import { FC, useEffect, useState } from 'react';
import cn from 'classnames';

import 'bulma/css/bulma.css';
import '@fortawesome/fontawesome-free/css/all.css';
import './App.scss';
import { User } from './types/User';
import { Post } from './types/Post';

import { getPosts, getUsers } from './utils/api';

import { PostsList } from './components/PostsList';
import { PostDetails } from './components/PostDetails';
import { UserSelector } from './components/UserSelector';
import { Loader } from './components/Loader';

export const App = () => (
<main className="section">
<div className="container">
<div className="tile is-ancestor">
<div className="tile is-parent">
<div className="tile is-child box is-success">
<div className="block">
<UserSelector />
</div>
import 'bulma/css/bulma.css';
import '@fortawesome/fontawesome-free/css/all.css';
import './App.scss';

<div className="block" data-cy="MainContent">
<p data-cy="NoSelectedUser">No user selected</p>
export const App: FC = () => {
const [users, setUsers] = useState<User[]>([]);
const [selectedUser, setSelectedUser] = useState<User | null>(null);

<Loader />
const [userPosts, setUserPosts] = useState<Post[]>([]);
const [selectedPost, setSelectedPost] = useState<Post | null>(null);

<div
className="notification is-danger"
data-cy="PostsLoadingError"
>
Something went wrong!
</div>
const [isLoading, setIsLoading] = useState(false);
const [isError, setIsError] = useState(false);

const noUsersPosts =
!userPosts.length && selectedUser && !isLoading && !isError;

useEffect(() => {
setIsLoading(true);
setIsError(false);

<div className="notification is-warning" data-cy="NoPostsYet">
No posts yet
getUsers()
.then(setUsers)
.catch(() => setIsError(true))
.finally(() => setIsLoading(false));
}, []);

useEffect(() => {
if (!selectedUser) {
return;
}

setIsLoading(true);
setIsError(false);
setUserPosts([]);
setSelectedPost(null);

getPosts(selectedUser.id)
.then(setUserPosts)
.catch(() => setIsError(true))
.finally(() => setIsLoading(false));
}, [selectedUser]);

Comment on lines +41 to +55
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous useEffect, using a try-catch block for error handling is recommended. This aligns with the checklist's suggestion to use try-catch for error handling.

return (
<main className="section">
<div className="container">
<div className="tile is-ancestor">
<div className="tile is-parent">
<div className="tile is-child box is-success">
<div className="block">
<UserSelector
users={users}
selectedUser={selectedUser}
onSelectUser={setSelectedUser}
/>
</div>

<PostsList />
<div className="block" data-cy="MainContent">
{!selectedUser && (
<p data-cy="NoSelectedUser">No user selected</p>
)}

{isLoading && <Loader />}

{isError && !isLoading && (
<div
className="notification is-danger"
data-cy="PostsLoadingError"
>
Something went wrong!
</div>
)}

{noUsersPosts && (
<div className="notification is-warning" data-cy="NoPostsYet">
No posts yet
</div>
)}

{!!userPosts.length && selectedUser && (
<PostsList
posts={userPosts}
selectedPost={selectedPost}
onSelectPost={setSelectedPost}
/>
)}
</div>
</div>
</div>
</div>

<div
data-cy="Sidebar"
className={classNames(
'tile',
'is-parent',
'is-8-desktop',
'Sidebar',
'Sidebar--open',
)}
>
<div className="tile is-child box is-success ">
<PostDetails />
<div
data-cy="Sidebar"
className={cn('tile', 'is-parent', 'is-8-desktop', 'Sidebar', {
'Sidebar--open': selectedPost,
})}
>
<div className="tile is-child box is-success ">
{selectedPost && <PostDetails post={selectedPost} />}
</div>
</div>
</div>
</div>
</div>
</main>
);
</main>
);
};
Loading
Loading