Solution #854
Open
Solution #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loralevitska
suggested changes
Jul 13, 2023
There was a problem hiding this comment.
Good job! There are things that should be fixed:
- try to fix empty fields with string.trim()
src/App.tsx
Outdated
| const [selectedUser, setSelectedUser] = useState<User | null>(null); | ||
| const [posts, setPosts] = useState<Post[] | null>(null); | ||
| const [currentPost, setCurrentPost] = useState<Post | null>(null); | ||
| const [loadingPosts, setLoadingPosts] = useState(false); |
There was a problem hiding this comment.
Fix it everywhere with tips on naming boolean variables
Suggested change
| const [loadingPosts, setLoadingPosts] = useState(false); | |
| const [isLoadingPosts, setIsLoadingPosts] = useState(false); |
src/App.tsx
Outdated
Comment on lines
31
to
35
| async function fetchUsers() { | ||
| const data = await client.get<User[]>('/users'); | ||
|
|
||
| setUsers(data); | ||
| } |
There was a problem hiding this comment.
Move this function out from useEffect
src/App.tsx
Outdated
Comment on lines
78
to
80
| const addComment = async ({ | ||
| postId, name, email, body, | ||
| }: CommentData) => { |
There was a problem hiding this comment.
Suggested change
| const addComment = async ({ | |
| postId, name, email, body, | |
| }: CommentData) => { | |
| const addComment = async ({ | |
| postId, | |
| name, | |
| email, | |
| body, | |
| }: CommentData) => { |
src/App.tsx
Outdated
|
|
||
| return [response]; | ||
| }); | ||
| } catch (error: any) { |
There was a problem hiding this comment.
Don't use any for types. Add the correct type here
src/components/PostDetails.tsx
Outdated
| {!loadingComments && comments && comments.length > 0 && ( | ||
| <p className="title is-4">Comments:</p>)} | ||
| {comments && comments.length > 0 && !loadingComments && comments.map( | ||
| comment => ( |
src/components/PostsList.tsx
Outdated
| voluptate et itaque vero tempora molestiae | ||
| </td> | ||
| <tbody> | ||
| {posts && posts.map(post => ( |
src/components/UserSelector.tsx
Outdated
| <a | ||
| href={`#user-${user.id}`} | ||
| key={user.id} | ||
| className={`dropdown-item ${selectedUser && selectedUser.id === user.id ? 'is-active' : ''}`} |
There was a problem hiding this comment.
Use classnames library to add classes conditionally
sTorba24
suggested changes
Jul 15, 2023
src/App.tsx
Outdated
| <div className="notification is-warning" data-cy="NoPostsYet"> | ||
| No posts yet | ||
| </div> | ||
| {posts && posts.length === 0 && ( |
There was a problem hiding this comment.
Suggested change
| {posts && posts.length === 0 && ( | |
| {posts && !posts.length && ( |
src/components/PostsList.tsx
Outdated
| voluptate et itaque vero tempora molestiae | ||
| </td> | ||
| <tbody> | ||
| {posts && posts.map(post => ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://VadymTsyndra.github.io/react_dynamic-list-of-posts