Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added solution #857

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

added solution #857

wants to merge 3 commits into from

Conversation

sheva10barca
Copy link

etojeDenys
etojeDenys suggested changes Jul 18, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. selected user name should appear in the custom select
image
  1. let's show only the loader when we change user
Screen.Recording.2023-07-18.at.20.39.09.mov
  1. let's also add the loader when we change post comments

etojeDenys
etojeDenys suggested changes Jul 19, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. still can reproduce second bug in prev comment
  2. let's change the type of this input to email
image 3. let's hide errors in such cases image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanFesenko IvanFesenko IvanFesenko approved these changes

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheva10barca @IvanFesenko @etojeDenys